Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level

[Peter Lieven]

Am 07.07.2015 um 15:24 schrieb Stefan Hajnoczi:
> On Tue, Jul 7, 2015 at 1:08 PM, Stefan Hajnoczi <address@hidden> wrote:
> > From: Peter Lieven <address@hidden>
> >
> > upcoming libnfs versions will support logging debug messages. Add
> > support for it in qemu through a per-drive option.
> >
> > Examples:
> >   qemu -drive if=virtio,file=nfs://...,file.debug=2
> >   qemu-img create -o debug=2 nfs://... 10G
> >
> > Signed-off-by: Peter Lieven <address@hidden>
> > Reviewed-by: Fam Zheng <address@hidden>
> > Message-id: address@hidden
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
> > ---
> >   block/nfs.c          | 28 ++++++++++++++++++++++++----
> >   qapi/block-core.json | 20 ++++++++++++++++----
> >   2 files changed, 40 insertions(+), 8 deletions(-)
> Kevin has pointed out at the QAPI portion of this patch isn't ready
> for prime time yet, so I will revert the patch and resend the pull
> request.

Yes please, I was not aware that adding the QAPI part
has such an impact. I would appreciate if someone who has
more experience with the QAPI stuff would look at this and
make a proposal how to handle the NFS (and also the iSCSI)
case. I'm happy to look at the implementation then.

Peter