[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw |
Date: |
Tue, 7 Jul 2015 20:16:29 +0100 |
On 7 July 2015 at 19:06, Denis V. Lunev <address@hidden> wrote:
> On 07/07/15 20:13, Olga Krishtal wrote:
>>
>> Peter, can you try this patch on your system?
>>
>> In mingw older than mingw64-headers-4.0.2-1.el7.noarch
>> header ntddscsi.h can be found in include/ddk, however
>> compiler does not look there. This breaks the compilation.
>>
>> The patch adds this directory in QEMU_INCLUDES.
>>
>> Signed-off-by: Olga Krishtal <address@hidden>
>> ---
>> configure | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 52cfe18..ada8895 100755
>> --- a/configure
>> +++ b/configure
>> @@ -3763,7 +3763,6 @@ if test "$usb_redir" != "no" ; then
>> usb_redir="no"
>> fi
>> fi
>> -
>> ##########################################
>> # check if we have VSS SDK headers for win
>>
>> @@ -3820,6 +3819,14 @@ if test "$mingw32" = "yes" -a "$guest_agent" !=
>> "no" -a "$guest_agent_with_vss"
>> fi
>>
>> ##########################################
>> +# mingw package on Linux is quite different with different versions.
>> ntddscsi.h
>> +# can be found sys-root/mingw/include and in sys-root/mingw/include/ddk
>> +# Add ddk directory to lookup path automatically
>> +if test "$mingw32" = "yes" -a "$guest_agent" != "no"; then
>> + QEMU_INCLUDES="$QEMU_INCLUDES -I`$cc -print-sysroot`/mingw/include/ddk"
>> +fi
>> +
>> +##########################################
>> # Guest agent Window MSI package
>>
>> if test "$guest_agent" != yes; then
>>
>
> actually this is a dirty hack, but we want to
> know whether additional include directory help or not.
> If this helps, we could think how to avoid extra
> configuration option and ifdef in the code.
I agree it's a pretty nasty hack :-)
Unfortunately my build machine is going to be running
flat out processing all the last-minute pull requests.
I won't be able to test this until tomorrow at best.
-- PMM
- [Qemu-devel] [PATCH 05/10] qga: win32 qmp_guest_network_get_interfaces implementation, (continued)
- [Qemu-devel] [PATCH 05/10] qga: win32 qmp_guest_network_get_interfaces implementation, Michael Roth, 2015/07/07
- [Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality., Michael Roth, 2015/07/07
- Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0, Peter Maydell, 2015/07/07
- Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0, Olga Krishtal, 2015/07/07
- Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0, Olga Krishtal, 2015/07/07
- Re: [Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0, Peter Maydell, 2015/07/07
- [Qemu-devel] [PATCH] qga: fix build for older versions of mingw, Olga Krishtal, 2015/07/07
- Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw, Denis V. Lunev, 2015/07/07
- Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw, Michael Roth, 2015/07/07
- Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw, Denis V. Lunev, 2015/07/07
- Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw, Michael Roth, 2015/07/07
- Re: [Qemu-devel] [PATCH] qga: fix build for older versions of mingw, Peter Maydell, 2015/07/07