Re: [Qemu-devel] [PATCH qemu v10 00/14] spapr: vfio: Enable Dynamic DMA windows (DDW)

[David Gibson]

On Mon, Jul 06, 2015 at 05:54:56PM +0200, Thomas Huth wrote:
> On Mon,  6 Jul 2015 12:10:56 +1000
> Alexey Kardashevskiy <address@hidden> wrote:
> ...
> > 
> > This patchset adds DDW support for pseries. The host kernel changes are
> > required, available in the current upstream.
> > 
> > This patchset is based on git://github.com/dgibson/qemu.git spapr-next 
> > branch.
> > 
> > Please comment. Thanks!
> 
>  Alexey,
> 
> I'm sorry, but it looks like this patch set badly fails to link when
> compiling for a non-Linux target:
> 
>   LINK  ppc64-softmmu/qemu-system-ppc64.exe
> hw/ppc/spapr_pci.o: In function `spapr_phb_dma_capabilities_update':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:785: undefined reference to 
> `spapr_phb_vfio_dma_capabilities_update'
> hw/ppc/spapr_pci.o: In function `rtas_ibm_configure_pe':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:601: undefined reference to 
> `spapr_phb_vfio_eeh_configure'
> hw/ppc/spapr_pci.o: In function `rtas_ibm_set_slot_reset':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:573: undefined reference to 
> `spapr_phb_vfio_eeh_reset'
> hw/ppc/spapr_pci.o: In function `rtas_ibm_read_slot_reset_state2':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:533: undefined reference to 
> `spapr_phb_vfio_eeh_get_state'
> hw/ppc/spapr_pci.o: In function `rtas_ibm_set_eeh_option':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:455: undefined reference to 
> `spapr_phb_vfio_eeh_set_option'
> hw/ppc/spapr_pci.o: In function `spapr_phb_hotplug_dma_sync':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:884: undefined reference to 
> `spapr_phb_vfio_dma_remove_window'
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:894: undefined reference to 
> `spapr_phb_vfio_dma_init_window'
> hw/ppc/spapr_pci.o: In function `spapr_phb_dma_init_window':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:805: undefined reference to 
> `spapr_phb_vfio_dma_init_window'
> hw/ppc/spapr_pci.o: In function `spapr_phb_dma_remove_window':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:834: undefined reference to 
> `spapr_phb_vfio_dma_remove_window'
> hw/ppc/spapr_pci.o: In function `spapr_phb_reset':
> /home/thuth/devel/qemu/hw/ppc/spapr_pci.c:1538: undefined reference to 
> `spapr_phb_vfio_eeh_reenable'
> collect2: error: ld returned 1 exit status
> 
> Please make sure that this series also works if either CONFIG_LINUX
> or CONFIG_PCI are not enabled!

I don't think !CONFIG_PCI really needs handling - I think having
CONFIG_PSERIES enabled without CONFIG_PCI is simply a configuration
error - another thing to handle when and if we ever encode config
dependencies in qemu.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgpDxfFfQx1kR.pgp
Description: PGP signature