[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/10] target-i386: Tidy gen_add_A0_im
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 09/10] target-i386: Tidy gen_add_A0_im |
Date: |
Thu, 9 Jul 2015 08:15:21 +0100 |
Merge gen_op_addl_A0_im and gen_op_addq_A0_im into gen_add_A0_im
and clean up the ifdef.
Replace the one remaining user of gen_op_addl_A0_im with gen_add_A0_im.
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
target-i386/translate.c | 27 +++++----------------------
1 file changed, 5 insertions(+), 22 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 17d3aa6..de2c34b 100644
--- a/target-i386/translate.c
+++ b/target-i386/translate.c
@@ -379,29 +379,12 @@ static inline void gen_op_mov_v_reg(TCGMemOp ot, TCGv t0,
int reg)
}
}
-static inline void gen_op_addl_A0_im(int32_t val)
-{
- tcg_gen_addi_tl(cpu_A0, cpu_A0, val);
-#ifdef TARGET_X86_64
- tcg_gen_andi_tl(cpu_A0, cpu_A0, 0xffffffff);
-#endif
-}
-
-#ifdef TARGET_X86_64
-static inline void gen_op_addq_A0_im(int64_t val)
-{
- tcg_gen_addi_tl(cpu_A0, cpu_A0, val);
-}
-#endif
-
static void gen_add_A0_im(DisasContext *s, int val)
{
-#ifdef TARGET_X86_64
- if (CODE64(s))
- gen_op_addq_A0_im(val);
- else
-#endif
- gen_op_addl_A0_im(val);
+ tcg_gen_addi_tl(cpu_A0, cpu_A0, val);
+ if (!CODE64(s)) {
+ tcg_gen_ext32u_tl(cpu_A0, cpu_A0);
+ }
}
static inline void gen_op_jmp_v(TCGv dest)
@@ -6262,7 +6245,7 @@ static target_ulong disas_insn(CPUX86State *env,
DisasContext *s,
exception */
gen_op_jmp_v(cpu_T[0]);
/* pop selector */
- gen_op_addl_A0_im(1 << dflag);
+ gen_add_A0_im(s, 1 << dflag);
gen_op_ld_v(s, dflag, cpu_T[0], cpu_A0);
gen_op_movl_seg_T0_vm(R_CS);
/* add stack offset */
--
2.4.3
- [Qemu-devel] [PATCH 01/10] target-i386: Create gen_lea_v_seg, (continued)
- [Qemu-devel] [PATCH 01/10] target-i386: Create gen_lea_v_seg, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 02/10] target-i386: Introduce mo_stacksize, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 03/10] target-i386: Use gen_lea_v_seg in gen_lea_modrm, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 04/10] target-i386: Use gen_lea_v_seg in stack subroutines, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 05/10] target-i386: Access segs via TCG registers, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 06/10] target-i386: Use gen_lea_v_seg in pusha/popa, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 07/10] target-i386: Rewrite gen_enter inline, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 08/10] target-i386: Rewrite leave, Richard Henderson, 2015/07/09
- [Qemu-devel] [PATCH 09/10] target-i386: Tidy gen_add_A0_im,
Richard Henderson <=
- [Qemu-devel] [PATCH 10/10] target-i386: Deconstruct the cpu_T array, Richard Henderson, 2015/07/09
- Re: [Qemu-devel] [PATCH 00/10] target-i386 addressing cleanups, Paolo Bonzini, 2015/07/09