[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge |
Date: |
Tue, 14 Jul 2015 11:49:11 +0300 |
On Tue, Jul 14, 2015 at 04:42:44PM +0800, Chen, Tiejun wrote:
> >>>diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
> >>>index 4356af4..703148e 100644
> >>>--- a/include/hw/xen/xen.h
> >>>+++ b/include/hw/xen/xen.h
> >>>@@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr);
> >>> # define HVM_MAX_VCPUS 32
> >>> #endif
> >>>
> >>>+extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t
> >>>gpu_dev_id);
> >>> #endif /* QEMU_HW_XEN_H */
> >>
> >>You are right that I was confused on my previous comment, but it is true
> >>that it shouldn't be part of this patch: it should be part of patch
>
> Right.
>
> >>7/10. Also the declaration should probably not be in the xen.h header.
> >>
> >>Michael, where do you think should go?
> >
> >Donnu - add a header?
> >
>
> What about the include/hw/i386/pc.h file?
>
> Thanks
> Tiejun
Somewhat ugly, but OK I guess.
- [Qemu-devel] [v9][PATCH 03/10] piix: create host bridge to passthrough, (continued)
- [Qemu-devel] [v9][PATCH 03/10] piix: create host bridge to passthrough, Tiejun Chen, 2015/07/07
- [Qemu-devel] [v9][PATCH 01/10] i440fx: make types configurable at run-time, Tiejun Chen, 2015/07/07
- [Qemu-devel] [v9][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support, Tiejun Chen, 2015/07/07
- [Qemu-devel] [v9][PATCH 04/10] hw/pci-assign: split pci-assign.c, Tiejun Chen, 2015/07/07
- [Qemu-devel] [v9][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work, Tiejun Chen, 2015/07/07
- [Qemu-devel] [v9][PATCH 07/10] igd gfx passthrough: create a isa bridge, Tiejun Chen, 2015/07/07
- [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge, Tiejun Chen, 2015/07/07
[Qemu-devel] [v9][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough, Tiejun Chen, 2015/07/07
[Qemu-devel] [v9][PATCH 10/10] xen, gfx passthrough: add opregion mapping, Tiejun Chen, 2015/07/07