[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 0/2] QOM: object_property_add() performance impro
From: |
Pavel Fedin |
Subject: |
[Qemu-devel] [PATCH v4 0/2] QOM: object_property_add() performance improvement |
Date: |
Tue, 14 Jul 2015 12:38:59 +0300 |
The function originally behaves very badly when adding properties with "[*]"
suffix. Normally these are used for numbering IRQ pins. In order to find the
correct starting number the function started from zero and checked for
duplicates. This takes incredibly long time with large number of CPUs because
number of IRQ pins on some architectures (like ARM GICv3) gets multiplied by
number of CPUs.
The solution is to add one more property which caches last used index so that
duplication check is not repeated thousands of times. Every time an array is
expanded the index is picked up from this cache.
The modification decreases qemu startup time with 32 CPUs by a factor of 2
(~10 sec vs ~20 sec).
Pavel Fedin (2):
QOM: Introduce object_property_add_single()
QOM: object_property_add() performance improvement
qom/object.c | 96 +++++++++++++++++++++++++++++++++++++++++++-----------------
1 file changed, 69 insertions(+), 27 deletions(-)
--
1.9.5.msysgit.0
- [Qemu-devel] [PATCH v4 0/2] QOM: object_property_add() performance improvement,
Pavel Fedin <=
- [Qemu-devel] [PATCH v4 1/2] QOM: Introduce object_property_add_single(), Pavel Fedin, 2015/07/14
- [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement, Pavel Fedin, 2015/07/14
- Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement, Daniel P. Berrange, 2015/07/27
- Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement, Markus Armbruster, 2015/07/27
- Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement, Pavel Fedin, 2015/07/27
- Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement, Andreas Färber, 2015/07/27
- Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement, Paolo Bonzini, 2015/07/27