[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported b
|
From: |
Aurelien Jarno |
|
Subject: |
Re: [Qemu-devel] [PATCH] target-mips: fix logically dead code reported by Coverity |
|
Date: |
Tue, 14 Jul 2015 18:26:26 +0200 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On 2015-07-14 17:22, Leon Alrae wrote:
> On 14/07/2015 16:45, Aurelien Jarno wrote:
> > By the way, is this debug code really useful? I think by looking at the
> > TCG code (-d in_asm,op), it's easy to determine if an instruction is
> > correctly disassembled or not.
> >
>
> For me this debug code doesn't seem to be useful at all and it only clutters
> translate.c :) In this patch I just wanted to make Coverity happy so I
> followed the existing code but generally would vote for removal all of
> MIPS_DEBUG.
Ok, I'll work on a patch for 2.5. That said I think we should still
merge the patch for 2.4.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
address@hidden http://www.aurel32.net