[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scs
From: |
Jason Wang |
Subject: |
Re: [Qemu-devel] [PATCH V2 2/5] virtio-blk: advertise scsi only when scsi is set |
Date: |
Wed, 15 Jul 2015 16:31:44 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 |
On 07/15/2015 03:57 PM, Paolo Bonzini wrote:
>
> On 15/07/2015 07:29, Jason Wang wrote:
>> Cc: Stefan Hajnoczi <address@hidden>
>> Cc: Kevin Wolf <address@hidden>
>> Cc: address@hidden
>> Signed-off-by: Jason Wang <address@hidden>
>> ---
>> hw/block/virtio-blk.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
>> index 4c27974..761d763 100644
>> --- a/hw/block/virtio-blk.c
>> +++ b/hw/block/virtio-blk.c
>> @@ -731,7 +731,9 @@ static uint64_t virtio_blk_get_features(VirtIODevice
>> *vdev, uint64_t features,
>> virtio_add_feature(&features, VIRTIO_BLK_F_GEOMETRY);
>> virtio_add_feature(&features, VIRTIO_BLK_F_TOPOLOGY);
>> virtio_add_feature(&features, VIRTIO_BLK_F_BLK_SIZE);
>> - virtio_add_feature(&features, VIRTIO_BLK_F_SCSI);
>> + if (s->conf.scsi) {
>> + virtio_add_feature(&features, VIRTIO_BLK_F_SCSI);
>> + }
> This must only be done for newer machine types only, or you change guest
> ABI for scsi=off. Effectively you have to split it in two properties,
> "scsi" and "always_set_f_scsi".
>
> Paolo
And always_set_f_scsi is true only for legacy machine types?
- [Qemu-devel] [PATCH V2 0/5] Set correct blk feature for virtio 1.0, Jason Wang, 2015/07/15
- [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Jason Wang, 2015/07/15
- Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Michael S. Tsirkin, 2015/07/15
- Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Paolo Bonzini, 2015/07/15
- Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Michael S. Tsirkin, 2015/07/15
- Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Paolo Bonzini, 2015/07/15
- Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Michael S. Tsirkin, 2015/07/15
- Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default, Paolo Bonzini, 2015/07/15
[Qemu-devel] [PATCH V2 4/5] virtio-blk: fail the init when both 1.0 and scsi is set, Jason Wang, 2015/07/15
[Qemu-devel] [PATCH V2 5/5] virtio-blk: set VIRTIO_F_ANY_LAYOUT when 1.0 is supported, Jason Wang, 2015/07/15