|
| From: | Nils Carlson |
| Subject: | Re: [Qemu-devel] [PATCH] qemu-char: Fix missed data on unix socket |
| Date: | Wed, 15 Jul 2015 23:44:52 +0200 (CEST) |
| User-agent: | Alpine 2.02 (DEB 1266 2009-07-14) |
On Mon, 13 Jul 2015, Nils Carlson wrote:
On Mon, 13 Jul 2015, Amit Shah wrote:
<snip>
Also, returning TRUE there isn't right - if the connection ends, we should return FALSE.I agree that this seems reasonable. I will change it and re-test.
I had a closer look, and it seems always returning true is intentional here, the called function, tcp_chr_disconnect(chr), handles the deregistration from handlers. If we were to return FALSE we would be duplicating work and possibly breaking things.
Nils
Amit
| [Prev in Thread] | Current Thread | [Next in Thread] |