[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [Qemu-devel] [PATCH V4 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set |
|
Date: |
Mon, 27 Jul 2015 14:23:37 +0300 |
On Mon, Jul 27, 2015 at 12:39:44PM +0200, Cornelia Huck wrote:
> On Mon, 27 Jul 2015 12:28:23 +0200
> Paolo Bonzini <address@hidden> wrote:
>
> > On 27/07/2015 11:49, Jason Wang wrote:
> > > + if (__virtio_has_feature(features, VIRTIO_F_VERSION_1)) {
> >
> > No double underscores in userspace code. Longstanding so it can be
> > fixed after 2.4 is out---but please remember to do it.
>
> There's https://marc.info/?l=qemu-devel&m=142599436726514&w=2
> which seems to have been lost in all that virtio rebasing.
Right.
Pls repost after 2.4.
--
MST
[Qemu-devel] [PATCH V4 3/3] virtio-blk: only clear VIRTIO_F_ANY_LAYOUT for legacy device, Jason Wang, 2015/07/27
Re: [Qemu-devel] [PATCH V4 0/3] Set correct blk feature for virtio 1.0, Paolo Bonzini, 2015/07/27