Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement

[Paolo Bonzini]

On 28/07/2015 08:45, Pavel Fedin wrote:
>  I can try to reengineer this and see what happens. If it works fine, will 
> such rework be accepted? [*] expansion would still be slow, but we could 
> deprecate it.
> 
>  I have just done a search of "[*]" across all *.c files, and here is what i 
> came up with:
> 1. memory_region_init()
> 2. xlnx_zynqmp_init()
> 3. qdev_init_gpio_in_named()
> 4. qdev_init_gpio_out_named()
> 5. qdev_connect_gpio_out_named()
> 6. spapr_dr_connector_new()
> 
>  Cases 2, 3, 4 can be reengineered for sure. The rest - i don't know, however 
> perhaps they are not common cases. I think (1) could also be problematic. How 
> many regions with the same name can we have?

Just worry about 3 and 4, they are the big offenders.

Paolo