Re: [Qemu-devel] [PATCH] tcg/mips: fix add2

[Richard Henderson]

On 07/31/2015 08:31 AM, Aurelien Jarno wrote:
> The add2 code in the tcg_out_addsub2 function doesn't take into account
> the case where rl == al == bl. In that case we can't compute the carry
> after the addition. As it corresponds to a multiplication by 2, the
> carry bit is the bit 31.
>
> While this is a corner case, this prevents x86-64 guests to boot on a
> MIPS host.
>
> Cc: Richard Henderson<address@hidden>
> Signed-off-by: Aurelien Jarno<address@hidden>
> ---
>   tcg/mips/tcg-target.c | 3 +++
>   1 file changed, 3 insertions(+)

Reviewed-by: Richard Henderson <address@hidden>


r~