[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/12] qemu-common.h: Move muldiv64() to host-ut
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 08/12] qemu-common.h: Move muldiv64() to host-utils.h |
Date: |
Fri, 31 Jul 2015 18:32:43 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jul 22, 2015 at 05:44:07PM +0100, Peter Maydell wrote:
> Move the muldiv64() function from qemu-common.h to host-utils.h.
> This puts it together with all the other arithmetic functions
> where we provide a version with __int128_t and a fallback
> without, and allows headers which need muldiv64() to avoid
> including qemu-common.h.
>
> We don't include host-utils from qemu-common.h, to avoid dragging
> more things into qemu-common.h than it already has; in practice
> everywhere that needs muldiv64() can get it via qemu/timer.h.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> include/qemu-common.h | 31 -------------------------------
> include/qemu/host-utils.h | 29 +++++++++++++++++++++++++++++
> include/qemu/timer.h | 1 +
> 3 files changed, 30 insertions(+), 31 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH 06/12] osdep.h: Move some OS header includes and fixups from qemu-common.h, (continued)
- [Qemu-devel] [PATCH 04/12] compiler.h: Use glue() in QEMU_BUILD_BUG_ON define, Peter Maydell, 2015/07/22
- [Qemu-devel] [PATCH 09/12] apic_internal.h: Include cpu.h directly, Peter Maydell, 2015/07/22
- [Qemu-devel] [PATCH 03/12] osdep.h: Move some compiler-specific things to compiler.h, Peter Maydell, 2015/07/22
- [Qemu-devel] [PATCH 07/12] osdep.h: Add header comment, Peter Maydell, 2015/07/22
- [Qemu-devel] [PATCH 08/12] qemu-common.h: Move muldiv64() to host-utils.h, Peter Maydell, 2015/07/22
- Re: [Qemu-devel] [PATCH 08/12] qemu-common.h: Move muldiv64() to host-utils.h,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 02/12] osdep.h: Remove qemu_printf, Peter Maydell, 2015/07/22
- [Qemu-devel] [PATCH 05/12] qemu-common.h: Move Win32 fixups into os-win32.h, Peter Maydell, 2015/07/22
- Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring, Paolo Bonzini, 2015/07/22
- Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring, Markus Armbruster, 2015/07/23
- Re: [Qemu-devel] [PATCH 00/12] qemu-common.h/osdep.h refactoring, Daniel P. Berrange, 2015/07/31