[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] target-mips: Copy restrictions from ext/ins
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/3] target-mips: Copy restrictions from ext/ins to dext/dins |
|
Date: |
Mon, 3 Aug 2015 12:29:50 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/03/2015 11:49 AM, Richard Henderson wrote:
> #if defined(TARGET_MIPS64)
> - case OPC_DEXTM:
> - tcg_gen_shri_tl(t0, t1, lsb);
> - if (msb != 31) {
> - tcg_gen_andi_tl(t0, t0, (1ULL << (msb + 1 + 32)) - 1);
> - }
> - break;
> case OPC_DEXTU:
> - tcg_gen_shri_tl(t0, t1, lsb + 32);
> - tcg_gen_andi_tl(t0, t0, (1ULL << (msb + 1)) - 1);
> - break;
> + lsb += 32;
> + /* FALLTHRU */
> + case OPC_DEXTM:
> + msb += 32;
> + /* FALLTHRU */
> case OPC_DEXT:
> + if (lsb + msb > 63) {
> + goto fail;
> + }
Apologies: this bit is wrong for DEXTU. I'll re-send.
r~
[Qemu-devel] [PATCH 3/3] target-mips: Use CPU_LOG_INT for logging related to interrupts, Richard Henderson, 2015/08/03