Re: [Qemu-devel] [PATCH v3 2/2] make: load only required dependency files.

[Victor Kaplansky]

On Sun, Aug 09, 2015 at 12:54:37PM +0100, Peter Maydell wrote:
> On 9 August 2015 at 12:39, Michael S. Tsirkin <address@hidden> wrote:
> > On Sun, Aug 09, 2015 at 12:39:59PM +0300, Victor Kaplansky wrote:
> >> -        $(eval -include $(addsuffix *.d, $(sort $(dir $($v)))))
> >> +        $(eval -include $(patsubst %.o,%.d,$(patsubst %.mo,%.d,$($v))))
> >>          $(eval $v := $(filter-out %/,$($v))))
> >>  endef
> >
> > Please add space after each comma.
> 
> (I thought we discussed this in v1 review?)
> 
> We don't seem to be completely consistent in our makefile
> style, but I would say that the majority of it is written
> in the same style used in the GNU Make docs, with no spaces
> after commas.

Looking into qemu sources I see that most patsubst patterns are written
without spaces after first comma.  About the same situation is in linux
kernel sources.  So, as for now, the style recommendation probably would
be not to use spaces, but spaces after comma are acceptable.

If we want to change this style recommendation, we can create another
cosmetic patch addressing the change in style.

-- Victor