[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC v4 3/9] softmmu: Add helpers for a new slowpath

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [RFC v4 3/9] softmmu: Add helpers for a new slowpath
Date: Tue, 11 Aug 2015 15:52:40 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0

On 11/08/2015 15:32, alvise rigo wrote:
>> > +#if DATA_SIZE > 1
>> > +#define helper_ldlink_name  glue(glue(helper_le_ldlink, USUFFIX), 
>> > +#define helper_stcond_name  glue(glue(helper_le_stcond, SUFFIX), 
>> > +#define helper_ld_legacy glue(glue(helper_le_ld, USUFFIX), MMUSUFFIX)
>> > +#define helper_st_legacy glue(glue(helper_le_st, SUFFIX), MMUSUFFIX)
> Wouldn't be better here to not use the helpers from softmmu_template.h?
> Doing so, in softmmu_template.h we don't need to differentiate the
> normal stores from the SCs
> This at a cost of some additional boilerplate in softmmu_llsc_template.h.

A lot more boilerplate I think?

This patch looks good, I would just s/_legacy// because it's not really


reply via email to

[Prev in Thread] Current Thread [Next in Thread]