Re: [Qemu-devel] [RFC v4 3/9] softmmu: Add helpers for a new slowpath

[alvise rigo]

On Tue, Aug 11, 2015 at 3:52 PM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 11/08/2015 15:32, alvise rigo wrote:
>>> > +#if DATA_SIZE > 1
>>> > +#define helper_ldlink_name  glue(glue(helper_le_ldlink, USUFFIX), 
>>> > MMUSUFFIX)
>>> > +#define helper_stcond_name  glue(glue(helper_le_stcond, SUFFIX), 
>>> > MMUSUFFIX)
>>> > +#define helper_ld_legacy glue(glue(helper_le_ld, USUFFIX), MMUSUFFIX)
>>> > +#define helper_st_legacy glue(glue(helper_le_st, SUFFIX), MMUSUFFIX)
>> Wouldn't be better here to not use the helpers from softmmu_template.h?
>> Doing so, in softmmu_template.h we don't need to differentiate the
>> normal stores from the SCs
>> This at a cost of some additional boilerplate in softmmu_llsc_template.h.
>
> A lot more boilerplate I think?
>
> This patch looks good, I would just s/_legacy// because it's not really
> legacy.

Agreed.

alvise

>
> Paolo