Re: [Qemu-devel] [PATCH for-2.5 15/30] m68k: add more modes to movem

[Richard Henderson]

On 08/12/2015 01:07 AM, Andreas Schwab wrote:
> Richard Henderson <address@hidden> writes:
> 
>> On 08/09/2015 01:13 PM, Laurent Vivier wrote:
>>> +    opsize = (insn & 0x40) != 0 ? OS_LONG : OS_WORD;
>>> +    incr = opsize_bytes(opsize);
>>> +    if (!is_load && (insn & 070) == 040) {
>>> +        for (i = 15; i >= 0; i--, mask >>= 1) {
>>
>> This has got to be wrong.  Just because it's pre-decrement doesn't mean
>> you should skip all of the loads.
> 
> Pre-dec only supports reg-to-mem, and is special because mask is bit
> reversed.

Ah, I'd never noticed that.  A comment to that effect would be good.


r~