qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/5] target-arm: there is no TTBR1 for 32-bit EL


From: Edgar E. Iglesias
Subject: Re: [Qemu-devel] [PATCH 1/5] target-arm: there is no TTBR1 for 32-bit EL2 stage 1 translations
Date: Mon, 17 Aug 2015 03:38:26 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Fri, Jul 24, 2015 at 04:20:59PM +0100, Peter Maydell wrote:
> For EL2 stage 1 translations, there is no TTBR1. We were already
> handling this for 64-bit EL2; add the code to take the 'no TTBR1'
> code path for 64-bit EL2 as well.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Edgar E. Iglesias <address@hidden>


> ---
>  target-arm/helper.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 01f0d0d..1ac6594 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5638,6 +5638,11 @@ static bool get_phys_addr_lpae(CPUARMState *env, 
> target_ulong address,
>          if (el > 1) {
>              ttbr1_valid = false;
>          }
> +    } else {
> +        /* There is no TTBR1 for EL2 */
> +        if (el == 2) {
> +            ttbr1_valid = false;
> +        }
>      }
>  
>      /* Determine whether this address is in the region controlled by
> -- 
> 1.9.1
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]