[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all ma
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines |
Date: |
Tue, 18 Aug 2015 13:06:33 -0700 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Tue, Aug 18, 2015 at 12:08:53PM -0700, Eduardo Habkost wrote:
[...]
> - env->gregs[1] = 0; // Memory start
> - env->gregs[2] = ram_size; // Memory size
> - env->gregs[3] = 0; // Machine description XXX
> + env->gregs[1] = 0; /* Memory start */
> + env->gregs[2] = ram_size; /* Memory size */
> + env->gregs[3] = 0; /* Machine description XXX */
[...]
> - pci_dev->config[0x04] = 0x06; // command = bus master, pci mem
> + pci_dev->config[0x04] = 0x06; /* command = bus master, pci mem */
> pci_dev->config[0x05] = 0x00;
> - pci_dev->config[0x06] = 0xa0; // status = fast back-to-back, 66MHz, no
> error
> - pci_dev->config[0x07] = 0x03; // status = medium devsel
> - pci_dev->config[0x09] = 0x00; // programming i/f
> - pci_dev->config[0x0D] = 0x0a; // latency_timer
> + pci_dev->config[0x06] = 0xa0; /* status = fast back-to-back, 66MHz, no
> error */
> + pci_dev->config[0x07] = 0x03; /* status = medium devsel */
> + pci_dev->config[0x09] = 0x00; /* programming i/f */
> + pci_dev->config[0x0D] = 0x0a; /* latency_timer */
The script was not supposed to touch those lines. I will fix it in the
next version.
--
Eduardo
- [Qemu-devel] [PATCH 2/7] exynos4: Use MachineClass instead of exynos4_machines array, (continued)
- [Qemu-devel] [PATCH 2/7] exynos4: Use MachineClass instead of exynos4_machines array, Eduardo Habkost, 2015/08/18
- [Qemu-devel] [PATCH 3/7] exynos4: Declare each QEMUMachine as a separate variable, Eduardo Habkost, 2015/08/18
- [Qemu-devel] [PATCH 4/7] machine: DEFINE_MACHINE macro, Eduardo Habkost, 2015/08/18
- [Qemu-devel] [PATCH 1/7] exynos4: Use EXYNOS4210_NCPUS instead of max_cpus on error message, Eduardo Habkost, 2015/08/18
- [Qemu-devel] [PATCH 5/7] pc: Use DEFINE_MACHINE to implement DEFINE_PC_MACHINE, Eduardo Habkost, 2015/08/18
- [Qemu-devel] [PATCH 7/7] machine: Eliminate QEMUMachine and qemu_register_machine(), Eduardo Habkost, 2015/08/18
- [Qemu-devel] [PATCH 6/7] [RFC] Use DEFINE_MACHINE to register all machines, Eduardo Habkost, 2015/08/18