qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] ne2000: Drop ne2000_can_receive


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH v2] ne2000: Drop ne2000_can_receive
Date: Thu, 20 Aug 2015 02:52:02 +0800
User-agent: Mutt/1.5.23 (2014-03-12)

On Fri, 07/03 11:41, Stefan Hajnoczi wrote:
> On Fri, Jul 03, 2015 at 09:08:41AM +0800, Fam Zheng wrote:
> > This moves the behavior of ne2000_can_receive to ne2000_receive. The
> > logic is when the NIC is stopped we drop the packet, when the buffer is
> > full we queue it and try flush later.
> > 
> > ne2000_buffer_full is determined by s->curpag, s->boundary, s->start and
> > s->stop. Add a flush in ne2000_ioport_write as they are all updated
> > there, except the advancing of s->curpag in ne2000_receive where
> > ne2000_buffer_full is already false.
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  hw/net/ne2000-isa.c |  1 -
> >  hw/net/ne2000.c     | 27 ++++++++++++++++-----------
> >  2 files changed, 16 insertions(+), 12 deletions(-)
> 
> Thanks, applied to my net tree:
> https://github.com/stefanha/qemu/commits/net
> 

Hi Stefan, I just notice there is still no pull req for this?

Fam




reply via email to

[Prev in Thread] Current Thread [Next in Thread]