[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer based outputs |
Date: |
Fri, 21 Aug 2015 00:37:55 +0200 |
Hi
On Thu, Aug 6, 2015 at 8:28 PM, Kővágó, Zoltán <address@hidden> wrote:
>
> - decr = rate_get_samples(&hw->info, &out->rate);
> - decr = audio_MIN(out->fsize - out->fpos, decr);
> -
> - *size = decr << 2;
> + *size = audio_rate_get_bytes(&hw->info, &out->rate,
> + (out->fsize - out->fpos) << 2);
> return out->frame + out->fpos;
> }
I am not familiar with this "rate" thing, but you are changing the way
it works for Spice without explaining why, and that worries me a
little.
The rate->bytes_sent is not updated the same way, the result is not
always << 2..
I really don't get what this is really doing tbh, some kind of clever
buffer limit :)
--
Marc-André Lureau
- Re: [Qemu-devel] [PATCH 17/25] audio: remove gcc specific audio_MIN, audio_MAX, (continued)
- [Qemu-devel] [PATCH 14/25] audio: audiodev= parameters no longer optional when -audiodev present, Kővágó, Zoltán, 2015/08/06
- [Qemu-devel] [PATCH 22/25] audio: add mixeng option (documentation), Kővágó, Zoltán, 2015/08/06
- [Qemu-devel] [PATCH 13/25] audio: add audiodev properties to frontends, Kővágó, Zoltán, 2015/08/06
- [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer based outputs, Kővágó, Zoltán, 2015/08/06
- Re: [Qemu-devel] [PATCH 21/25] audio: common rate control code for timer based outputs,
Marc-André Lureau <=
- [Qemu-devel] [PATCH 05/25] qapi: change Netdev into a flat union, Kővágó, Zoltán, 2015/08/06
- [Qemu-devel] [PATCH 11/25] audio: reduce glob_audio_state usage, Kővágó, Zoltán, 2015/08/06
- [Qemu-devel] [PATCH 12/25] audio: basic support for multi backend audio, Kővágó, Zoltán, 2015/08/06
- [Qemu-devel] [PATCH 08/25] qapi: support nested structs in OptsVisitor, Kővágó, Zoltán, 2015/08/06