[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 suppor
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support |
Date: |
Tue, 25 Aug 2015 16:17:42 +0100 |
On 13 August 2015 at 18:09, Wei Huang <address@hidden> wrote:
> This patch adds support for SMBIOS 3.0 entry point. When caller invokes
> smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then
> smbios_get_tables() will return the entry point table in right format.
> -/* SMBIOS entry point (anchor).
> - * BIOS must place this at a 16-bit-aligned address between 0xf0000 and
> 0xfffff.
> +/* SMBIOS entry point
> + * BIOS must place this at a 16-bit-aligned address between 0xf0000
> + * and 0xfffff.
> */
> -struct smbios_entry_point {
> +struct smbios_21_entry_point {
> uint8_t anchor_string[4];
> uint8_t checksum;
> uint8_t length;
> @@ -58,6 +52,25 @@ struct smbios_entry_point {
> uint8_t smbios_bcd_revision;
> } QEMU_PACKED;
This breaks 'make check' for x86, because tests/bios-tables-test.c
still uses 'struct smbios_entry_point' and no longer compiles
if this patch is applied.
I'm removing these two patches from my target-arm queue.
thanks
-- PMM
- [Qemu-devel] [ARM SMBIOS V4 PATCH 0/2] SMBIOS Support for ARM, Wei Huang, 2015/08/13
- [Qemu-devel] [ARM SMBIOS V4 PATCH 2/2] smbios: implement smbios support for mach-virt, Wei Huang, 2015/08/13
- [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Wei Huang, 2015/08/13
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Laszlo Ersek, 2015/08/13
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support,
Peter Maydell <=
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Leif Lindholm, 2015/08/25
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Wei Huang, 2015/08/25
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Peter Maydell, 2015/08/25
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Wei Huang, 2015/08/26
- Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 1/2] smbios: add smbios 3.0 support, Leif Lindholm, 2015/08/26
Re: [Qemu-devel] [ARM SMBIOS V4 PATCH 0/2] SMBIOS Support for ARM, Peter Maydell, 2015/08/19