[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers a
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol" |
Date: |
Thu, 27 Aug 2015 14:53:52 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote:
> diff --git a/include/block/aio.h b/include/block/aio.h
> index bd1d44b..d02ddfa 100644
> --- a/include/block/aio.h
> +++ b/include/block/aio.h
> @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx);
> bool aio_dispatch(AioContext *ctx);
>
> #define AIO_CLIENT_UNSPECIFIED (1 << 0)
> +#define AIO_CLIENT_PROTOCOL (1 << 1)
The semantics need to be documented here, not just in the commit
description.
AIO_CLIENT_BLOCK_DRIVER or AIO_CLIENT_BLOCK_PROTOCOL seems like a
clearer name to me since "protocol" just by itself could mean many
things.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol",
Stefan Hajnoczi <=