[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 18/18] linux-user: remove useless macros GUEST_BA
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PULL 18/18] linux-user: remove useless macros GUEST_BASE and RESERVED_VA |
Date: |
Fri, 28 Aug 2015 10:55:52 +0200 |
On Fri, 28 Aug 2015 10:33:25 +0200
Laurent Vivier <address@hidden> wrote:
>
>
> Le 28/08/2015 10:21, Cornelia Huck a écrit :
> > On Mon, 24 Aug 2015 12:37:06 -0700
> > Richard Henderson <address@hidden> wrote:
> >
> >> From: Laurent Vivier <address@hidden>
> >>
> >> As we have removed CONFIG_USE_GUEST_BASE, we always use a guest base
> >> and the macros GUEST_BASE and RESERVED_VA become useless: replace
> >> them by their values.
> >>
> >> Reviewed-by: Alexander Graf <address@hidden>
> >> Signed-off-by: Laurent Vivier <address@hidden>
> >> Message-Id: <address@hidden>
> >> Signed-off-by: Richard Henderson <address@hidden>
> >> ---
> >> include/exec/cpu-all.h | 4 +---
> >> include/exec/cpu_ldst.h | 8 ++++----
> >> linux-user/mmap.c | 20 ++++++++++----------
> >> tcg/aarch64/tcg-target.c | 10 +++++-----
> >> tcg/arm/tcg-target.c | 8 ++++----
> >> tcg/i386/tcg-target.c | 22 +++++++++++-----------
> >> tcg/ia64/tcg-target.c | 21 +++++++++------------
> >> tcg/mips/tcg-target.c | 16 ++++++++--------
> >> tcg/ppc/tcg-target.c | 12 ++++--------
> >> tcg/s390/tcg-target.c | 13 ++++---------
> >> tcg/sparc/tcg-target.c | 8 ++++----
> >> 11 files changed, 64 insertions(+), 78 deletions(-)
> >
> > This seems to break compilation on s390 for me:
> >
> > In file included from /home/cohuck/git/qemu/tcg/tcg.c:258:0:
> > /home/cohuck/git/qemu/tcg/s390/tcg-target.c: In function
> > ‘tcg_target_qemu_prologue’:
> > /home/cohuck/git/qemu/tcg/s390/tcg-target.c:2347:9: error: ‘guest_base’
> > undeclared (first use in this function)
> > if (guest_base >= 0x80000) {
> > ^
> > (once for each of the softmmu subdirs I build)
> >
> > config.log says:
> >
> > # Configured with: '/home/cohuck/git/qemu/build/../configure'
> > '--target-list=s390x-softmmu s390x-linux-user aarch64-softmmu arm-softmmu
> > mips-softmmu ppc-softmmu ppc64-softmmu' '--enable-kvm' '--enable-vhost-net'
> > '--enable-virtio-blk-data-plane' '--enable-linux-aio'
>
> I've tested the compilation for all targets but only on x86_64... :(
>
> The use of guest_base must be surrounded by "#ifndef CONFIG_SOFTMMU", it
> is not the case for s390 (see other host tcg).
>
> Can you fix this or do you want I write a patch ?
I'd prefer if you could do that.
- [Qemu-devel] [PULL 10/18] tcg: update README about size changing ops, (continued)
- [Qemu-devel] [PULL 10/18] tcg: update README about size changing ops, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 11/18] tcg: Split trunc_shr_i32 opcode into extr[lh]_i64_i32, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 13/18] tcg/i386: use softmmu fast path for unaligned accesses, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 14/18] tcg/ppc: Improve unaligned load/store handling on 64-bit backend, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 15/18] tcg/s390: Use softmmu fast path for unaligned accesses, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 16/18] tcg/aarch64: Use softmmu fast path for unaligned accesses, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 17/18] linux-user: remove --enable-guest-base/--disable-guest-base, Richard Henderson, 2015/08/24
- [Qemu-devel] [PULL 18/18] linux-user: remove useless macros GUEST_BASE and RESERVED_VA, Richard Henderson, 2015/08/24
- Re: [Qemu-devel] [PULL 00/18] Queued TCG patches, Peter Maydell, 2015/08/25