[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opt
Re: [Qemu-devel] [PATCH v3] opts: produce valid command line in qemu_opts_print
Fri, 28 Aug 2015 12:04:02 +0200
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
"Kővágó Zoltán" <address@hidden> writes:
> 2015-08-26 15:15 keltezéssel, Markus Armbruster írta:
>> Stefan Hajnoczi <address@hidden> writes:
>>> On Tue, Jul 7, 2015 at 3:42 PM, Kővágó, Zoltán
>>> <address@hidden> wrote:
>>>> This will let us print options in a format that the user would actually
>>>> write it on the command line (foo=bar,baz=asd,etc=def), without
>>>> prepending a spurious comma at the beginning of the list, or quoting
>>>> values unnecessarily. This patch provides the following changes:
>>>> * write and id=, if the option has an id
>>>> * do not print separator before the first element
>>>> * do not quote string arguments
>>>> * properly escape commas (,) for QEMU
>>>> Signed-off-by: Kővágó, Zoltán <address@hidden>
>>>> Reviewed-by: Markus Armbruster <address@hidden>
>>> Feel free to send a "Ping" email reply if your patches haven't been
>>> reviewed after about 1 week.
>>> Reviewed-by: Stefan Hajnoczi <address@hidden>
>> Route via qemu-trivial or qemu-block?
> Hmm, I originally intended qemu-trivial, qemu-block was added via
If I remember correctly, the initial patch didn't include the iotests
updates. The current one does.
Let's give the block maintainers a few days to take this patch. If none
of them bites, it's -trivial.