[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 04/23] s390x/css: start with cleared cstat/dstat
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PATCH 04/23] s390x/css: start with cleared cstat/dstat |
Date: |
Mon, 31 Aug 2015 13:13:44 +0200 |
When executing the start function, we should start with a clear state
regarding subchannel and device status; it is easy to forget updating one
of them after the ccw has been processed.
Note that we don't need to care about resetting the various control
fields: They are cleared by tsch(), and if they were still pending,
we wouldn't be able to execute the start function in the first
place.
Also note that we don't want to clear cstat/dstat if a suspended
subchannel is resumed.
This fixes a bug where we would continue to present channel-program
check in cstat even though later ccw requests for the subchannel
finished without error (i.e. cstat should be 0).
Cc: address@hidden
Signed-off-by: Cornelia Huck <address@hidden>
Reviewed-by: David Hildenbrand <address@hidden>
---
hw/s390x/css.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/s390x/css.c b/hw/s390x/css.c
index 9596280..c033612 100644
--- a/hw/s390x/css.c
+++ b/hw/s390x/css.c
@@ -399,6 +399,8 @@ static void sch_handle_start_func(SubchDev *sch, ORB *orb)
path = 0x80;
if (!(s->ctrl & SCSW_ACTL_SUSP)) {
+ s->cstat = 0;
+ s->dstat = 0;
/* Look at the orb and try to execute the channel program. */
assert(orb != NULL); /* resume does not pass an orb */
p->intparm = orb->intparm;
--
2.5.1
- [Qemu-devel] [PATCH 08/23] s390x/kvm: make setting of in-kernel irq routes more efficient, (continued)
- [Qemu-devel] [PATCH 08/23] s390x/kvm: make setting of in-kernel irq routes more efficient, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 19/23] s390/sclp: ignore memory hotplug operations if it is disabled, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 07/23] pc-bios/s390-ccw: rebuild image, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 18/23] s390: disallow memory hotplug for the s390-virtio machine, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 14/23] s390/sclp: introduce a root sclp device, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 10/23] sclp/s390: rework sclp cpu hotplug device notification, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 21/23] s390: unify allocation of initial memory, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 06/23] pc-bios/s390-ccw: Device detection in higher subchannel sets, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 15/23] s390/sclp: move sclp_execute related functions into the SCLP class, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 09/23] s390x/gdb: support reading/writing of control registers, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 04/23] s390x/css: start with cleared cstat/dstat,
Cornelia Huck <=
- [Qemu-devel] [PATCH 20/23] s390: move memory calculation into the sclp device, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 22/23] s390/sclp: store the increment_size in the sclp device, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 12/23] s390/sclp: replace sclp event types with proper defines, Cornelia Huck, 2015/08/31
- [Qemu-devel] [PATCH 23/23] s390/sclp: simplify calculation of rnmax, Cornelia Huck, 2015/08/31