[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members |
Date: |
Mon, 31 Aug 2015 10:13:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/31/2015 09:55 AM, Markus Armbruster wrote:
> We always report "should be a dictionary" then. This is misleading:
> when allow_dict, it can be a dictionary or a type name string, else it
> can only be a type name.
This exposes the current (poor) conditions; then it will be obvious what
improvements a later patch to fix it actually has.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/Makefile | 2 ++
> tests/qapi-schema/args-invalid.err | 1 +
> tests/qapi-schema/args-invalid.exit | 1 +
> tests/qapi-schema/args-invalid.json | 3 +++
> tests/qapi-schema/args-invalid.out | 0
> tests/qapi-schema/struct-data-invalid.err | 1 +
> tests/qapi-schema/struct-data-invalid.exit | 1 +
> tests/qapi-schema/struct-data-invalid.json | 3 +++
> tests/qapi-schema/struct-data-invalid.out | 0
> tests/qapi-schema/struct-member-invalid.err | 1 +
> tests/qapi-schema/struct-member-invalid.exit | 1 +
> tests/qapi-schema/struct-member-invalid.json | 3 +++
> tests/qapi-schema/struct-member-invalid.out | 0
> 13 files changed, 17 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again, (continued)
- [Qemu-devel] [PATCH v2 24/26] qapi-commands: Don't feed output of mcgen() to mcgen() again, Markus Armbruster, 2015/08/28
- [Qemu-devel] [PATCH 27/31] qapi: Drop one of two "simple union must not have base" checks, Markus Armbruster, 2015/08/31
- [Qemu-devel] [PATCH 31/31] qapi: Simplify error reporting for array types, Markus Armbruster, 2015/08/31
- [Qemu-devel] [PATCH 28/31] tests/qapi-schema: Cover two more syntax errors, Markus Armbruster, 2015/08/31
- [Qemu-devel] [PATCH 30/31] qapi: Fix errors for non-string, non-dictionary members, Markus Armbruster, 2015/08/31
- [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members, Markus Armbruster, 2015/08/31
- Re: [Qemu-devel] [PATCH 29/31] tests/qapi-schema: Cover non-string, non-dictionary members,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v2 00/26] qapi: Another round of fixes and cleanups, Markus Armbruster, 2015/08/31