[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH V2 5/8] memory: don't try to adjust endianness for z
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PATCH V2 5/8] memory: don't try to adjust endianness for zero length eventfd |
Date: |
Wed, 2 Sep 2015 11:25:22 +0800 |
There's no need to adjust endianness for zero length eventfd since the
data wrote was actually ignored by kernel. So skip the adjust in this
case to fix a possible crash when trying to use wildcard mmio eventfd
in ppc.
Cc: Greg Kurz <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
memory.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/memory.c b/memory.c
index 0d8b2d9..de2d999 100644
--- a/memory.c
+++ b/memory.c
@@ -1653,7 +1653,9 @@ void memory_region_add_eventfd(MemoryRegion *mr,
};
unsigned i;
- adjust_endianness(mr, &mrfd.data, size);
+ if (size) {
+ adjust_endianness(mr, &mrfd.data, size);
+ }
memory_region_transaction_begin();
for (i = 0; i < mr->ioeventfd_nb; ++i) {
if (memory_region_ioeventfd_before(mrfd, mr->ioeventfds[i])) {
@@ -1686,7 +1688,9 @@ void memory_region_del_eventfd(MemoryRegion *mr,
};
unsigned i;
- adjust_endianness(mr, &mrfd.data, size);
+ if (size) {
+ adjust_endianness(mr, &mrfd.data, size);
+ }
memory_region_transaction_begin();
for (i = 0; i < mr->ioeventfd_nb; ++i) {
if (memory_region_ioeventfd_equal(mrfd, mr->ioeventfds[i])) {
--
2.1.4
[Qemu-devel] [PATCH V2 5/8] memory: don't try to adjust endianness for zero length eventfd,
Jason Wang <=
[Qemu-devel] [PATCH V2 6/8] virtio-pci: use wildcard mmio eventfd for 1.0 notification cap, Jason Wang, 2015/09/01
[Qemu-devel] [PATCH V2 7/8] virtio-pci: introduce pio notification capability for modern device, Jason Wang, 2015/09/01
[Qemu-devel] [PATCH V2 8/8] virtio-pci: unbreak queue_enable read, Jason Wang, 2015/09/01
Re: [Qemu-devel] [PATCH V2 0/8] virtio 1.0 pci optimizations and fixes, Michael S. Tsirkin, 2015/09/10
Re: [Qemu-devel] [PATCH V2 0/8] virtio 1.0 pci optimizations and fixes, Michael S. Tsirkin, 2015/09/24