[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unus
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unused, drop it |
Date: |
Thu, 3 Sep 2015 14:42:56 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 09/03/2015 08:30 AM, Markus Armbruster wrote:
> 'gen': false needs to stay for now, because netdev_add is still using
> it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> +++ b/tests/Makefile
> @@ -228,7 +228,7 @@ check-qapi-schema-y := $(addprefix tests/qapi-schema/, \
> bad-type-dict.json double-data.json unknown-expr-key.json \
> redefined-type.json redefined-command.json redefined-builtin.json \
> redefined-event.json command-int.json bad-data.json event-max.json \
> - type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \
> + type-bypass-bad-gen.json \
> args-invalid.json \
> args-array-empty.json args-array-unknown.json args-int.json \
> args-unknown.json args-member-unknown.json args-member-array.json \
Not for this patch, but we aren't very consistent on any form of sorting
or line length in this section. It might be nicer if it were one test
per line (lots more line continuations) and/or alphabetical order. If
that sounds nice, then it's a trivial patch to add in as one of the
followups after this series lands.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH RFC v4 05/32] tests/qapi-schema: Convert test harness to QAPISchemaVisitor, (continued)
- [Qemu-devel] [PATCH RFC v4 21/32] qapi-commands: Rearrange code, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 26/32] qapi: Introduce a first class 'any' type, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 24/32] qapi-commands: De-duplicate output marshaling functions, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 32/32] qapi-introspect: Hide type names, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 27/32] qom: Don't use 'gen': false for qom-get, qom-set, object-add, Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 22/32] qapi: Rename qmp_marshal_input_FOO() to qmp_marshal_FOO(), Markus Armbruster, 2015/09/03
- [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unused, drop it, Markus Armbruster, 2015/09/03
- Re: [Qemu-devel] [PATCH RFC v4 29/32] qapi: Pseudo-type '**' is now unused, drop it,
Eric Blake <=
- [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection, Markus Armbruster, 2015/09/03
- Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection, Michael Roth, 2015/09/03
- Re: [Qemu-devel] [PATCH RFC v4 30/32] qapi: New QMP command query-schema for QMP schema introspection, Eric Blake, 2015/09/03