[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from m
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c |
Date: |
Tue, 8 Sep 2015 11:54:46 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/09/2015 09:09, Denis V. Lunev wrote:
> qemu-monitor-info.texi | 151 +++++++
This should be added in patch 4, not now.
> +const MonitorDef *target_monitor_defs(void) __attribute__((weak));
> +
> +const MonitorDef *target_monitor_defs(void)
> +{
> + return NULL;
> +}
Weak symbols do not work on all platforms. Luckily, making libqemustub
a static library gets exactly the same result without the need for weak
symbols: the definition from the QEMU object files will hide the stub.
You just need to remove __attribute__((weak)), and it should just work.
Otherwise, the patches look good to me. Luiz, do you have time to post
a pull request for v4, or do you want to pass HMP maintainership as well
to someone else?
Paolo
- [Qemu-devel] [PATCH v3 0/4] Move target- and device specific code from monitor, Denis V. Lunev, 2015/09/08
- [Qemu-devel] [PATCH 3/4] hmp-commands.hx: fix end of table info, Denis V. Lunev, 2015/09/08
- [Qemu-devel] [PATCH 4/4] monitor: added generation of documentation for hmp-commands-info.hx, Denis V. Lunev, 2015/09/08
- [Qemu-devel] [PATCH 1/4] hmp-commands-info: move info_cmds content out of monitor.c, Denis V. Lunev, 2015/09/08
- [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Denis V. Lunev, 2015/09/08
- Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Luiz Capitulino, 2015/09/08
- Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Paolo Bonzini, 2015/09/08
- Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Luiz Capitulino, 2015/09/08
- Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Paolo Bonzini, 2015/09/08
- Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c, Stefan Hajnoczi, 2015/09/09