[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 10/10] xen/pt: Don't slurp wholesale the PCI conf
From: |
Konrad Rzeszutek Wilk |
Subject: |
[Qemu-devel] [PATCH v2 10/10] xen/pt: Don't slurp wholesale the PCI configuration registers |
Date: |
Tue, 8 Sep 2015 10:10:02 -0400 |
Instead we have the emulation registers ->init functions which
consult the host values to see what the initial value should be
and they are responsible for populating the dev.config.
Reviewed-by: Stefano Stabellini <address@hidden>
Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
---
hw/xen/xen_pt.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index 80b687f..0f66ea1 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -774,12 +774,7 @@ static int xen_pt_initfn(PCIDevice *d)
}
/* Initialize virtualized PCI configuration (Extended 256 Bytes) */
- rc = xen_host_pci_get_block(&s->real_device, 0, d->config,
- PCI_CONFIG_SPACE_SIZE);
- if (rc < 0) {
- XEN_PT_ERR(d,"Could not read PCI_CONFIG space! (rc:%d)\n", rc);
- goto err_out;
- }
+ memset(d->config, 0, PCI_CONFIG_SPACE_SIZE);
s->memory_listener = xen_pt_memory_listener;
s->io_listener = xen_pt_io_listener;
--
2.1.0
- [Qemu-devel] [PATCH v2] Remove XenPTReg->data and use dev.config for guest configuration values., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 10/10] xen/pt: Don't slurp wholesale the PCI configuration registers,
Konrad Rzeszutek Wilk <=
- [Qemu-devel] [PATCH v2 09/10] xen/pt: Check for return values for xen_host_pci_[get|set] in init, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 05/10] xen/pt: Log xen_host_pci_get in two init functions, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 07/10] xen/pt: Make xen_pt_unregister_device idempotent, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 08/10] xen/pt: Move bulk of xen_pt_unregister_device in its own routine., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 04/10] xen/pt: Remove XenPTReg->data field., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 02/10] xen/pt: Sync up the dev.config and data values., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 03/10] xen/pt: Check if reg->init function sets the 'data' past the reg->size, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 06/10] xen/pt: Log xen_host_pci_get/set errors in MSI code., Konrad Rzeszutek Wilk, 2015/09/08