[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI +
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors. |
Date: |
Tue, 8 Sep 2015 16:22:01 +0100 |
User-agent: |
Alpine 2.02 (DEB 1266 2009-07-14) |
Applied
On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote:
> Hey!
>
> Since v2 (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00431.html)
> - Added Reviewed-by.
>
> since RFC
> [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07326.html]
> - Added Acks
> - Followed 'xen: Print and use errno where applicable.' suggestion by Stefano
> and added a wrapper.
>
> As I am in the process of syncing the 'dev.config' and Xen's internal
> cache of the PCI config space I noticed that some oddities
> in the code and figured that having them in would be easier
> for me (so I don't have to handle 20 odd patches).
>
> Stefano, patch
>
> [PATCH v2 4/6] xen: use errno instead of rc for
>
> was the only one that changed - where I implemented the configure script
> as you suggested. All the rest are the same.
>
> Please review or git pull the following tag:
>
> git://xenbits.xen.org/people/konradwilk/qemu.git
> v2-cleanups-fixes-due-to-libxlABI
>
>
> configure | 26 ++++++++++++++++++++++++++
> hw/xen/xen_pt.c | 6 +++---
> hw/xen/xen_pt.h | 1 -
> hw/xen/xen_pt_config_init.c | 8 ++++----
> hw/xen/xen_pt_msi.c | 2 +-
> include/hw/xen/xen_common.h | 22 ++++++++++++++++++++++
> xen-hvm.c | 4 ++--
> 7 files changed, 58 insertions(+), 11 deletions(-)
>
> Konrad Rzeszutek Wilk (6):
> xen/pt: Update comments with proper function name.
> xen/pt: Make xen_pt_msi_set_enable static
> xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure
> xen: use errno instead of rc for xc_domain_add_to_physmap
> xen/pt/msi: Add the register value when printing logging and error
> messages
> xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings.
>
- [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 6/6] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings., Konrad Rzeszutek Wilk, 2015/09/08
- Re: [Qemu-devel] [PATCH v2] Cleanups + various fixes due to libxl ABI + more logging on errors.,
Stefano Stabellini <=
- [Qemu-devel] [PATCH v2 3/6] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 1/6] xen/pt: Update comments with proper function name., Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 5/6] xen/pt/msi: Add the register value when printing logging and error messages, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 2/6] xen/pt: Make xen_pt_msi_set_enable static, Konrad Rzeszutek Wilk, 2015/09/08
- [Qemu-devel] [PATCH v2 4/6] xen: use errno instead of rc for xc_domain_add_to_physmap, Konrad Rzeszutek Wilk, 2015/09/08