[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_to_opc |
Date: |
Tue, 8 Sep 2015 19:46:56 +0100 |
On 2 September 2015 at 06:52, Richard Henderson <address@hidden> wrote:
> The gen_opc_* arrays are already redundant with the data stored in
> the insn_start arguments. Transition restore_state_to_opc to use
> data from the later.
Typo: "latter".
> Signed-off-by: Richard Henderson <address@hidden>
> diff --git a/tcg/tcg.c b/tcg/tcg.c
> index a44b834..d956f0b 100644
> --- a/tcg/tcg.c
> +++ b/tcg/tcg.c
> @@ -1007,7 +1007,6 @@ void tcg_dump_ops(TCGContext *s)
> a = args[i];
> #endif
> qemu_log(" " TARGET_FMT_lx, a);
> -
> }
> } else if (c == INDEX_op_call) {
> /* variable number of arguments */
Stray whitespace change.
Otherwise
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH 15/20] target-*: Drop cpu_gen_code define, (continued)
[Qemu-devel] [PATCH 20/20] tcg: Remove tcg_gen_code_search_pc, Richard Henderson, 2015/09/02
[Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_to_opc, Richard Henderson, 2015/09/02
- Re: [Qemu-devel] [PATCH 17/20] tcg: Pass data argument to restore_state_to_opc,
Peter Maydell <=
[Qemu-devel] [PATCH 19/20] tcg: Remove gen_intermediate_code_pc, Richard Henderson, 2015/09/02
Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Max Filippov, 2015/09/02
- Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Richard Henderson, 2015/09/02
- Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Max Filippov, 2015/09/04
- Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Peter Maydell, 2015/09/04
- Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Richard Henderson, 2015/09/04
- Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Max Filippov, 2015/09/04
- Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation, Mark Cave-Ayland, 2015/09/05