[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 2/5] migration: Parameters for auto-converge
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH v7 2/5] migration: Parameters for auto-converge cpu throttling |
Date: |
Wed, 09 Sep 2015 13:21:54 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Jason J. Herne" <address@hidden> wrote:
> @@ -344,6 +359,18 @@ void qmp_migrate_set_parameters(bool has_compress_level,
> "is invalid, it should be in the range of 1 to 255");
> return;
> }
> + if (has_x_cpu_throttle_initial &&
> + (x_cpu_throttle_initial < 1 || x_cpu_throttle_initial > 99)) {
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE,
> + "x_cpu_throttle_initial",
> + "an integer in the range of 1 to 99");
> + }
> + if (has_x_cpu_throttle_increment &&
> + (x_cpu_throttle_increment < 1 || x_cpu_throttle_increment > 99))
> {
> + error_set(errp, QERR_INVALID_PARAMETER_VALUE,
> + "x_cpu_throttle_increment",
> + "an integer in the range of 1 to 99");
> + }
s/error_set/error_setg/
the same than the rest of the file, and without that change it don't
even compile against Today master.
Done by me, no need to do anything.
Later, Juan.
[Qemu-devel] [PATCH v7 3/5] migration: Dynamic cpu throttling for auto-converge, Jason J. Herne, 2015/09/08