[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only |
Date: |
Wed, 9 Sep 2015 17:14:58 +0200 |
Hi
On Wed, Sep 9, 2015 at 11:48 AM, Paolo Bonzini <address@hidden> wrote:
>
>
> On 09/09/2015 11:28, Gerd Hoffmann wrote:
>> Setting other LC_* affects printf behavior and breaks QMP.
>> We don't have much beside menu item strings localized, so
>> restrict the locale setting to LC_MESSAGES.
>>
>> Signed-off-by: Gerd Hoffmann <address@hidden>
>
> Cc: address@hidden
>
>> ---
>> ui/gtk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index a17b1d1..a0b2340 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>> @@ -1950,7 +1950,7 @@ void gtk_display_init(DisplayState *ds, bool
>> full_screen, bool grab_on_hover)
>>
>> s->free_scale = FALSE;
>>
>> - setlocale(LC_ALL, "");
>> + setlocale(LC_MESSAGES, "");
>> bindtextdomain("qemu", CONFIG_QEMU_LOCALEDIR);
>> textdomain("qemu");
>>
>>
>
Don't it need gtk_disable_setlocale() too? (it's marked deprecated in
gtk2, but not in gtk3 interesting)
In the previous thread, Markus suggested a fat comment, you could
place it above the call.
--
Marc-André Lureau
- [Qemu-devel] [PATCH 0/6] gtk: tweak grab handling, misc fixes., Gerd Hoffmann, 2015/09/09
- [Qemu-devel] [PATCH 4/6] gtk: set free_scale when setting zoom_fit, Gerd Hoffmann, 2015/09/09
- [Qemu-devel] [PATCH 2/6] gtk: move gd_update_caption calls to gd_{grab, ungrab}_{pointer, keyboard}, Gerd Hoffmann, 2015/09/09
- [Qemu-devel] [PATCH 1/6] gtk: check for existing grabs in gd_grab_{pointer, keyboard}, Gerd Hoffmann, 2015/09/09
- [Qemu-devel] [PATCH 6/6] gtk: setlocale for LC_MESSAGES only, Gerd Hoffmann, 2015/09/09
- [Qemu-devel] [PATCH 5/6] gtk: don't grab input when entering fullscreen., Gerd Hoffmann, 2015/09/09
- [Qemu-devel] [PATCH 3/6] gtk: trace input grab reason, Gerd Hoffmann, 2015/09/09