Re: [Qemu-devel] [PATCH v3 1/4] pci: remove Link Training error from AER error list

[Michael S. Tsirkin]

On Thu, Sep 10, 2015 at 11:39:35AM +0200, Paolo Bonzini wrote:
> The spec says:
> 
> Undefined – The value read from this bit is
> undefined. In previous versions of this
> specification, this bit was used to indicate a Link
> Training Error. System software must ignore the
> value read from this bit. System software is
> permitted to write any value to this bit.
> 
> Do not allow injecting it.
> 
> Suggested-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Reviewed-by: Michael S. Tsirkin <address@hidden>

> ---
>  hw/pci/pcie_aer.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c
> index f1847ac..46e0ad8 100644
> --- a/hw/pci/pcie_aer.c
> +++ b/hw/pci/pcie_aer.c
> @@ -827,10 +827,6 @@ typedef struct PCIEAERErrorName {
>   */
>  static const struct PCIEAERErrorName pcie_aer_error_list[] = {
>      {
> -        .name = "TRAIN",
> -        .val = PCI_ERR_UNC_TRAIN,
> -        .correctable = false,
> -    }, {
>          .name = "DLP",
>          .val = PCI_ERR_UNC_DLP,
>          .correctable = false,
> -- 
> 2.4.3
>