[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserve
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end |
Date: |
Thu, 10 Sep 2015 13:42:31 +0300 |
On Thu, Sep 10, 2015 at 11:59:07AM +0200, Igor Mammedov wrote:
> On Wed, 9 Sep 2015 17:03:56 -0300
> Eduardo Habkost <address@hidden> wrote:
>
> > On Mon, Sep 07, 2015 at 01:55:31PM +0200, Igor Mammedov wrote:
> > > reserved-memory-end tells firmware address from which
> > > it could start treating memory as PCI address space
> > > and map PCI BARs after it to avoid collisions with
> > > RAM.
> > > Currently it is incorrectly pointing to address where
> > > hotplugged memory range starts which could redirect
> > > hotplugged RAM accesses to PCI BARs when firmware
> > > maps them over RAM or viceverse.
> > > Fix this by pointing reserved-memory-end to the end
> > > of memory hotplug area.
> > >
> > > Signed-off-by: Igor Mammedov <address@hidden>
> >
> > Reviewed-by: Eduardo Habkost <address@hidden>
> >
> > But I would like to see this squashed into patch 2/2 (or the rebased
> > version of patch 2/2) to keep bisectability.
>
> Eduardo, thanks for review.
> It's ok squash 2/2, could you handle it and take it through your tree?
I merged them separately already:
I'm not too concerned about breaking cross version migration
being slightly racy when doing bisect.
--
MST