[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once |
Date: |
Thu, 10 Sep 2015 16:59:19 +0200 |
On Do, 2015-09-10 at 15:42 +0200, Marc-André Lureau wrote:
> Hi
>
> On Thu, Sep 10, 2015 at 3:22 PM, Gerd Hoffmann <address@hidden> wrote:
> >> > + glBindBuffer (GL_ARRAY_BUFFER, 0);
> >> > + glBindVertexArray (0);
> >> > + glDeleteBuffers (1, &buffer);
> >> > +
> >>
> >> extra space before (
> >
> > Fixed.
> >
> >> Is the unbinding necessary?
> >
> > Unbinding? Do you mam the DeleteBuffers?
> >
>
> The glBind..(.., 0)
>
> I think they shouldn't be necessary unless you have some other gl
> context sensitive code.
Just good style copied from sample code.
Probably it's not really needed here.
cheers,
Gerd
[Qemu-devel] [PATCH 2/9] sdl2: quick & dirty flicker workaround, Gerd Hoffmann, 2015/09/09
[Qemu-devel] [PATCH 3/9] ui/console: add opengl context and scanout support interfaces., Gerd Hoffmann, 2015/09/09
[Qemu-devel] [PATCH 9/9] gtk/opengl: add opengl context and scanout support (GtkGLArea), Gerd Hoffmann, 2015/09/09