[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI
From: |
Stefano Stabellini |
Subject: |
[Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code. |
Date: |
Thu, 10 Sep 2015 18:15:57 +0100 |
From: Konrad Rzeszutek Wilk <address@hidden>
We seem to only use these functions when de-activating the
MSI - so just log errors.
Reviewed-by: Stefano Stabellini <address@hidden>
Signed-off-by: Konrad Rzeszutek Wilk <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
---
hw/xen/xen_pt_msi.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_pt_msi.c b/hw/xen/xen_pt_msi.c
index 5822df5..e3d7194 100644
--- a/hw/xen/xen_pt_msi.c
+++ b/hw/xen/xen_pt_msi.c
@@ -75,19 +75,29 @@ static int msi_msix_enable(XenPCIPassthroughState *s,
bool enable)
{
uint16_t val = 0;
+ int rc;
if (!address) {
return -1;
}
- xen_host_pci_get_word(&s->real_device, address, &val);
+ rc = xen_host_pci_get_word(&s->real_device, address, &val);
+ if (rc) {
+ XEN_PT_ERR(&s->dev, "Failed to read MSI/MSI-X register (0x%x),
rc:%d\n",
+ address, rc);
+ return rc;
+ }
if (enable) {
val |= flag;
} else {
val &= ~flag;
}
- xen_host_pci_set_word(&s->real_device, address, val);
- return 0;
+ rc = xen_host_pci_set_word(&s->real_device, address, val);
+ if (rc) {
+ XEN_PT_ERR(&s->dev, "Failed to write MSI/MSI-X register (0x%x),
rc:%d\n",
+ address, rc);
+ }
+ return rc;
}
static int msi_msix_setup(XenPCIPassthroughState *s,
@@ -276,7 +286,7 @@ void xen_pt_msi_disable(XenPCIPassthroughState *s)
return;
}
- xen_pt_msi_set_enable(s, false);
+ (void)xen_pt_msi_set_enable(s, false);
msi_msix_disable(s, msi_addr64(msi), msi->data, msi->pirq, false,
msi->initialized);
--
1.7.10.4
- [Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge, (continued)
- [Qemu-devel] [PULL 09/29] xen, gfx passthrough: register a isa bridge, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 06/29] xen, gfx passthrough: basic graphics passthrough support, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 08/29] igd gfx passthrough: create a isa bridge, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 26/29] xen/pt: Make xen_pt_unregister_device idempotent, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 13/29] xen/HVM: atomically access pointers in bufioreq handling, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 12/29] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 22/29] xen/pt: Check if reg->init function sets the 'data' past the reg->size, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 28/29] xen/pt: Check for return values for xen_host_pci_[get|set] in init, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 14/29] xen/pt: Update comments with proper function name., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 25/29] xen/pt: Log xen_host_pci_get/set errors in MSI code.,
Stefano Stabellini <=
- [Qemu-devel] [PULL 24/29] xen/pt: Log xen_host_pci_get in two init functions, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 18/29] xen/pt/msi: Add the register value when printing logging and error messages, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 23/29] xen/pt: Remove XenPTReg->data field., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 11/29] xen, gfx passthrough: add opregion mapping, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 15/29] xen/pt: Make xen_pt_msi_set_enable static, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 16/29] xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 27/29] xen/pt: Move bulk of xen_pt_unregister_device in its own routine., Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 20/29] xen/pt: Use xen_host_pci_get_[byte|word] instead of dev.config, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 17/29] xen: use errno instead of rc for xc_domain_add_to_physmap, Stefano Stabellini, 2015/09/10
- [Qemu-devel] [PULL 19/29] xen/pt: Use XEN_PT_LOG properly to guard against compiler warnings., Stefano Stabellini, 2015/09/10