[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error set
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error setter logic |
Date: |
Fri, 11 Sep 2015 09:30:47 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 09/10/2015 11:33 PM, Peter Crosthwaite wrote:
> Currently set_error, set_error_errno, set_error_win32 do pretty much
> the same thing with only a little bit of string manipulation in the
> error code cases. Coreify that string manipulation as a callback and
> factor out the bulk of the error_set fns to a common helper that calls
> the callback at the right time.
>
Commit 5523750 pretty much already does this. This patch can be dropped
when rebasing the series to latest.
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> util/error.c | 81
> +++++++++++++++++++++++++-----------------------------------
> 1 file changed, 33 insertions(+), 48 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH v1 00/25] error: Automatic error concatenation and prefixing, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 01/25] exec: convert error_report to error_report_err, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 02/25] s390x: virtio-ccw: Remove un-needed if guard, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error setter logic, Peter Crosthwaite, 2015/09/11
- Re: [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error setter logic,
Eric Blake <=
- [Qemu-devel] [RFC PATCH v1 04/25] error: Add support for multiple errors, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 05/25] error: Add error prefix API, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 07/25] sysbus: mmio_map+mmio_get_region: ignore range OOB errors, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 06/25] error: Add error_printf_fn(), Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 08/25] memory: nop APIs when they have NULL arguments, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 09/25] qdev: gpio: Ignore unconnectable GPIOs, Peter Crosthwaite, 2015/09/11
- [Qemu-devel] [RFC PATCH v1 10/25] arm: xlnx-zynqmp: Update error API usages, Peter Crosthwaite, 2015/09/11