qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error set


From: Eric Blake
Subject: Re: [Qemu-devel] [RFC PATCH v1 03/25] error: Factor out common error setter logic
Date: Fri, 11 Sep 2015 09:30:47 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 09/10/2015 11:33 PM, Peter Crosthwaite wrote:
> Currently set_error, set_error_errno, set_error_win32 do pretty much
> the same thing with only a little bit of string manipulation in the
> error code cases. Coreify that string manipulation as a callback and
> factor out the bulk of the error_set fns to a common helper that calls
> the callback at the right time.
> 

Commit 5523750 pretty much already does this. This patch can be dropped
when rebasing the series to latest.

> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
> 
>  util/error.c | 81 
> +++++++++++++++++++++++++-----------------------------------
>  1 file changed, 33 insertions(+), 48 deletions(-)
> 


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]