[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/8] hw/cpu/{a15mpcore, a9mpcore}: Handle mis
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/8] hw/cpu/{a15mpcore, a9mpcore}: Handle missing has_el3 CPU props gracefully |
Date: |
Sun, 13 Sep 2015 19:13:46 -0700 |
On Sun, Sep 13, 2015 at 2:07 AM, Edgar E. Iglesias
<address@hidden> wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Handle missing CPU support for EL3 gracefully.
>
What is the use case here? A9 and A15 should be able to not have EL3,
but in this case the property should still exist but be set false. No
prop should only be the case with a CPU that can't ever support EL3.
Regards,
Peter
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> ---
> hw/cpu/a15mpcore.c | 2 +-
> hw/cpu/a9mpcore.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c
> index 4ef8db1..94e8cc1 100644
> --- a/hw/cpu/a15mpcore.c
> +++ b/hw/cpu/a15mpcore.c
> @@ -64,7 +64,7 @@ static void a15mp_priv_realize(DeviceState *dev, Error
> **errp)
> * either all the CPUs have TZ, or none do.
> */
> cpuobj = OBJECT(qemu_get_cpu(0));
> - has_el3 = object_property_find(cpuobj, "has_el3", &error_abort) &&
> + has_el3 = object_property_find(cpuobj, "has_el3", NULL) &&
> object_property_get_bool(cpuobj, "has_el3", &error_abort);
> qdev_prop_set_bit(gicdev, "has-security-extensions", has_el3);
> }
> diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c
> index 7046246..869818c 100644
> --- a/hw/cpu/a9mpcore.c
> +++ b/hw/cpu/a9mpcore.c
> @@ -69,7 +69,7 @@ static void a9mp_priv_realize(DeviceState *dev, Error
> **errp)
> * either all the CPUs have TZ, or none do.
> */
> cpuobj = OBJECT(qemu_get_cpu(0));
> - has_el3 = object_property_find(cpuobj, "has_el3", &error_abort) &&
> + has_el3 = object_property_find(cpuobj, "has_el3", NULL) &&
> object_property_get_bool(cpuobj, "has_el3", &error_abort);
> qdev_prop_set_bit(gicdev, "has-security-extensions", has_el3);
>
> --
> 1.9.1
>
>
- [Qemu-devel] [PATCH v2 0/8] arm: Steps towards EL2 support round 4, Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 1/8] hw/cpu/{a15mpcore, a9mpcore}: Handle missing has_el3 CPU props gracefully, Edgar E. Iglesias, 2015/09/13
- Re: [Qemu-devel] [PATCH v2 1/8] hw/cpu/{a15mpcore, a9mpcore}: Handle missing has_el3 CPU props gracefully,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v2 2/8] target-arm: Add VTCR_EL2, Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 3/8] target-arm: Add VTTBR_EL2, Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 4/8] target-arm: Suppress TBI for S2 translations, Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 5/8] target-arm: Suppress EPD for S2, EL2 and EL3 translations, Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 6/8] target-arm: Add VPIDR_EL2, Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 7/8] target-arm: Break out mpidr_read_val(), Edgar E. Iglesias, 2015/09/13
- [Qemu-devel] [PATCH v2 8/8] target-arm: Add VMPIDR_EL2, Edgar E. Iglesias, 2015/09/13
- Re: [Qemu-devel] [PATCH v2 0/8] arm: Steps towards EL2 support round 4, Peter Maydell, 2015/09/14