Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity()

[Eric Blake]

On 09/05/2015 10:43 AM, Vladimir Sementsov-Ogievskiy wrote:
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---

The commit message summary mentions a one-line "what" (good), but is
lacking a body that says "why" (that is, what was broken that needed
fixing?)

>  block.c               | 2 +-
>  include/block/block.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 

It looks like all the patch does is make the signature const-correct,
since querying the granularity does not modify the bitmap.  So the
commit message should say that.

With an improved commit message,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature