[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count
|
From: |
Leon Alrae |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] target-mips: Fix RDHWR on CP0.Count |
|
Date: |
Wed, 16 Sep 2015 10:05:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 |
On 16/09/15 06:27, Aurelien Jarno wrote:
> Independently of your patch, I do wonder if we shouldn't change the
> return type of cpu_mips_get_count to int32_t. With your patch, there
> are now 2 calls to this functions, and both cast the value to int32_t.
Yes, I think that will make more sense if the return type of
cpu_mips_get_count() matches CP0_Count.
Leon