[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] imx_serial: Generate interrupt on tx empty if e
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCH] imx_serial: Generate interrupt on tx empty if enabled |
Date: |
Wed, 16 Sep 2015 13:28:04 +0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 |
13.09.2015 23:17, Peter Crosthwaite wrote:
> On Fri, Sep 11, 2015 at 12:37 AM, Michael Tokarev <address@hidden> wrote:
>>
>> Can we please have some r-b or ACK for this? :)
>>
>> 20.08.2015 18:52, Guenter Roeck wrote:
>>> Generate an interrupt if the tx buffer is empty and the tx empty interrupt
>>> is enabled. This fixes a problem seen when running a Linux image since
>>> Linux commit 55c3cb1358e ("serial: imx: remove unneeded
>>> imx_transmit_buffer()
>>> from imx_start_tx()"). Linux now waits for the tx empty interrupt before
>>> starting to send data, causing transmit stalls until there is an interrupt
>>> for another reason.
>>>
>>> Signed-off-by: Guenter Roeck <address@hidden>
>
> Looks right, Jean-Christophe may know more though.
Thanks, applied to the trivial-patches tree :)
/mjt