Re: [Qemu-devel] [PATCH v3 21/46] ivshmem: use common return

[Claudio Fontana]

On 15.09.2015 18:07, address@hidden wrote:
> From: Marc-André Lureau <address@hidden>
> 
> Both if branches return, move this out to common end.
> 
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  hw/misc/ivshmem.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
> index a60454f..e391396 100644
> --- a/hw/misc/ivshmem.c
> +++ b/hw/misc/ivshmem.c
> @@ -525,13 +525,12 @@ static void ivshmem_read(void *opaque, const uint8_t 
> *buf, int size)
>          if (incoming_posn >= 0 && s->vm_id == -1) {
>              /* receive our posn */
>              s->vm_id = incoming_posn;
> -            return;
>          } else {
>              /* otherwise an fd == -1 means an existing guest has gone away */
>              IVSHMEM_DPRINTF("posn %ld has gone away\n", incoming_posn);
>              close_guest_eventfds(s, incoming_posn);
> -            return;
>          }
> +        return;
>      }
>  
>      /* if the position is -1, then it's shared memory region fd */
> 

Reviewed-by: Claudio Fontana <address@hidden>