Re: [Qemu-devel] MAINTAINERS leaves too many files uncovered

[Daniel P. Berrange]

On Tue, Sep 22, 2015 at 11:13:57AM +0200, Markus Armbruster wrote:
> Paolo asked for an update.
> 
> Markus Armbruster <address@hidden> writes:
> 
> > Markus Armbruster <address@hidden> writes:
> >
> >> In my experience, too many files are not covered by MAINTAINERS.
> >> scripts/get_maintainer.pl falls back to git then, unless you say
> >> --no-git-fallback.  Copies sent there tends to annoy their recipients
> >> without accomplishing all that much.
> >>
> >> Two obvious improvements:
> >>
> >> * Easy: Flip scripts/get_maintainer.pl's default to --no-git-fallback.
> >>   I'll post the obvious patch, please raise your objections there.
> >>
> >> * Harder: improve MAINTAINERS coverage.
> >
> > A few folks have started doing that.  Much appreciated!
> >
> > I collected recent patches to MAINTAINERS, and reran my analysis.
> >
> >> Let me back up subjective experience with hard data.  The tree has quite
> >> a few files:
> >>
> >>     $ git-ls-files | wc -l
> >>     3746
> >
> > Now 3752.
> 
> Eleven months later, this is 4387.
> 
> >> Counting them by extension:
> >>
> >>     $ git-ls-files | sed -n 's#.*/##;s#.*\.##p' | sort | uniq -c | sort -nr
> >>        1836 c
> >>         818 h
> >>         133 out
> >>         105 S
> >>          97 objs
> >>          69 s
> >>          64 mak
> >>          48 json
> >>          47 py
> >>          41 txt
> >>          33 exit
> >>          33 err
> >>          16 xml
> >>          16 bin
> >>          13 rom
> >>          12 sh
> >>          12 dsl
> >> [Long tail that doesn't add up to anything interesting omitted]
> >>
> >> Let's look for .c not in MAINTAINERS:
> >>
> >> $ for i in `git-ls-files`; do [ "`scripts/get_maintainer.pl -f
> > --no-git-fallback $i`" ] || echo $i; done >unmaintained-files
> >>     $ grep -c '\.c$' unmaintained-files
> >>     1066
> >>
> >> That's almost 60%.  Not good.
> >
> > Down to 491 our of 1841 (27%).  Progress, but not quite enough.
> 
> 461 out of 1945 (24%).  At this linear rate, we'll reach 10%
> unmaintained in five years.
> 
> We're still adding unmaintained .c files:
> 
>     $ git-diff --diff-filter=A --name-only e668d1b | grep -c '\.c$'
>     116
>     $ git-diff --diff-filter=A --name-only e668d1b | grep '\.c$' | join 
> unmaintained-files - | wc -l
>     37
> 
> 37 out of 116 new files (32%) are not covered.  That's worse than we do
> for old files.  Inexcusable.

We could extend the checkpatch.pl script so that it reports an error
if the patch contains a new file which is not covered by MAINTAINERS.
That would immediately prevent the situation getting any worse.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|