[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBac

From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 19/38] block: Fail requests to empty BlockBackend
Date: Tue, 22 Sep 2015 17:05:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0

On 22.09.2015 16:30, Kevin Wolf wrote:
> Am 18.09.2015 um 17:22 hat Max Reitz geschrieben:
>> If there is no BlockDriverState in a BlockBackend or if the tray of the
>> guest device is open, fail all requests (where that is possible) with
>> The reason the status of the guest device is taken into account is
>> because once the guest device's tray is opened, any request on the same
>> BlockBackend as the guest uses should fail. If the BDS tree is supposed
>> to be usable even after ejecting it from the guest, a different
>> BlockBackend must be used.
>> Signed-off-by: Max Reitz <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
> Do we want to include blk_drain() to make it a no-op instead of
> crashing?

Yes, we do, so that would be in patch 20. Thanks for catching that.

> Also, we're now introducing BlockAIOCBs with a NULL bs with your use of
> abort_aio_request. I haven't carefully reviewed the implications of this
> yet, but that should definitely be done before we merge the series.

That should be patch 12.


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]