[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP |
Date: |
Tue, 22 Sep 2015 17:23:13 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 18.09.2015 um 15:22 hat Markus Armbruster geschrieben:
> From: Eric Blake <address@hidden>
>
> Commits 7216ae3d and d2828429 disabled some error message hints,
> all because a change to use modern error reporting meant that the
> hint would be output prior to the actual error. Fix this by making
> hints a first-class member of Error.
>
> For example, we are now back to the pleasant:
>
> $ qemu-system-x86_64 --nodefaults -S --vnc :0 --chardev null,id=,
> qemu-system-x86_64: --chardev null,id=,: Parameter 'id' expects an identifier
> Identifiers consist of letters, digits, '-', '.', '_', starting with a
> letter.
>
> Signed-off-by: Eric Blake <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Message-Id: <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
This broke qemu-iotests 049. Can you please send a patch to update the
reference output?
Kevin
--- /home/kwolf/source/qemu/tests/qemu-iotests/049.out 2015-09-14
13:44:45.347890767 +0200
+++ 049.out.bad 2015-09-22 17:20:50.131625409 +0200
@@ -118,6 +118,7 @@
qemu-img create -f qcow2 -o size=foobar TEST_DIR/t.qcow2
qemu-img: Parameter 'size' expects a size
+You may use k, M, G or T suffixes for kilobytes, megabytes, gigabytes and
terabytes.
qemu-img: TEST_DIR/t.qcow2: Invalid options for file format 'qcow2'
== Check correct interpretation of suffixes for cluster size ==
- [Qemu-devel] [PULL 0/8] Error reporting patches, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 4/8] MAINTAINERS: Add "Error reporting" entry, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 3/8] error: Copy location information in error_copy(), Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 1/8] error: only prepend timestamp on stderr, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 7/8] loader: Fix memory_region_init_resizeable_ram() error handling, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP, Markus Armbruster, 2015/09/18
- Re: [Qemu-devel] [PULL 2/8] hmp: Allow for error message hints on HMP,
Kevin Wolf <=
- [Qemu-devel] [PULL 5/8] error: New error_fatal, Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 8/8] memory: Fix bad error handling in memory_region_init_ram_ptr(), Markus Armbruster, 2015/09/18
- [Qemu-devel] [PULL 6/8] Fix bad error handling after memory_region_init_ram(), Markus Armbruster, 2015/09/18
- Re: [Qemu-devel] [PULL 0/8] Error reporting patches, Peter Maydell, 2015/09/18