Re: [Qemu-devel] [PATCH v14 0/5] vGICv3 support

[Peter Maydell]

On 17 September 2015 at 10:27, Peter Maydell <address@hidden> wrote:
> On 9 September 2015 at 08:49, Pavel Fedin <address@hidden> wrote:
>> This series introduces support for GICv3 by KVM. Software emulation is
>> currently not supported.
>>
>> v13 => v14
>>
>> - Rebased on the latest master, fixed conflicts in hw/arm/virt.c
>>
>
> You'll need to fix the acpi related bits Shannon has review comments
> on in patch 5, but otherwise this looks good to me.

Having discussed this with Shannon yesterday, the fixes required
are trivial. Shannon kindly sent me this tiny patch, so I'm just
going to squash that into your patch 5 and put the whole lot into
target-arm.next, rather than make you have to go through another
round.


 hw/arm/virt-acpi-build.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 0dd7fce..59c84ff 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -454,8 +454,8 @@ build_madt(GArray *table_data, GArray *linker,
VirtGuestInfo *guest_info,

         gicr->type = ACPI_APIC_GENERIC_REDISTRIBUTOR;
         gicr->length = sizeof(*gicr);
-        gicr->base_address = memmap[VIRT_GIC_REDIST].base;
-        gicr->range_length = memmap[VIRT_GIC_REDIST].size;
+        gicr->base_address = cpu_to_le64(memmap[VIRT_GIC_REDIST].base);
+        gicr->range_length = cpu_to_le32(memmap[VIRT_GIC_REDIST].size);
     } else {
         for (i = 0; i < guest_info->smp_cpus; i++) {
             AcpiMadtGenericInterrupt *gicc = acpi_data_push(table_data,

thanks
-- PMM